Skip to content

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Apr 19, 2020

class TestSeriesGetitemListLike:
@pytest.mark.parametrize("box", [list, np.array, pd.Index, pd.Series])
def test_getitem_no_matches(self, box):
# GH#33462 we expect the same behavior for list/ndarray/Index/Serioes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Serioes -> Series

Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this closes #33642 instead (the OP references the pull request for some reason)

@jbrockmendel
Copy link
Member Author

updated, thanks

@jreback jreback added Bug Indexing Related to indexing on series/frames, not to indexes themselves labels Apr 19, 2020
@jreback jreback added this to the 1.1 milestone Apr 19, 2020
@jreback jreback merged commit 56d0934 into pandas-dev:master Apr 19, 2020
@jreback
Copy link
Contributor

jreback commented Apr 19, 2020

thanks

@jbrockmendel jbrockmendel deleted the 33642 branch April 19, 2020 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Indexing Related to indexing on series/frames, not to indexes themselves

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API: Series[index_with_no_matches] vs Series[list_with_no_matches]

3 participants